Tilebmpfile is coming as null

Bhavishya_Kumar · July 9, 2023, 12:56pm

Hi,
i am trying to write a solution using the tiled library for java but Library 1.2 version wasn’t printing tileID correctly so i switched to 1.4 where it had many issues because it was Saving wrong TilesetPath in TMX and TSX both where it was not detecting absolute path because of "file:" was inside the path string
i have fixed that personally in the source code and generated a new jar the issue was fixed

But now i am getting another issue the Tilebmpfile is coming as null in the latest java library for tiled i’ve tried multiple fixes in the reader but i think i am missing something because the issue was not fixed so can anyone tell me a quick fix for this? i believe its not detecting the URL as absolute again similar as the previous issue that’s why its saving Tileset Image file as null but its really problematic for me can anyone please assist me with this issue?
PS: This issue was not present in 1.2 BMP file was coming just file

tilesetImageFile = ImageIO.read(new File(tileset.getTilebmpFile());

Thanks

bjorn · July 27, 2023, 8:44am

I’m afraid libtiled-java is currently without a dedicated maintainer. If you have made any fixes however, you’re welcome to open a pull request for review. There have been several people making improvements and fixes to this library in the past year which could help verify the change.

getTilebmpFile is implemented as follows:

github.com

mapeditor/tiled/blob/cb4c33c599c811e0379cc4669e1bea77f258de3a/util/java/libtiled-java/src/main/java/org/mapeditor/core/TileSet.java#L386-L395


      
          public String getTilebmpFile() {
              if (tilebmpFile != null) {
                  try {
                      return tilebmpFile.getCanonicalPath();
                  } catch (IOException e) {
                  }
              }
          
              return null;
          }

Since File.getCanonicalPath is not documented to ever return null, the tilebmpFile member must be null in your case. This would mean the following function is never called, or called with null:

github.com

mapeditor/tiled/blob/cb4c33c599c811e0379cc4669e1bea77f258de3a/util/java/libtiled-java/src/main/java/org/mapeditor/core/TileSet.java#L248-L255


      
          public void setTilesetImageFilename(String name) {
              if (name != null) {
                  tilebmpFile = new File(name);
                  tilebmpFileLastModified = tilebmpFile.lastModified();
              } else {
                  tilebmpFile = null;
              }
          }

That function is only called from the String version of importTileBitmap. When the URL version has been used, tilebmpFile is never set. So, this problem appears to have been caused by the following change:

Would you be able to provide a patch, that makes sure to set tilebmpFile as appropriate for the URL version of importTileBitmap? I’m not sure what’s the best way to handle this, but it seems to me like setTilesetImageFilename could just be changed to take a URL and use it to construct the File using new File(url.toURI()). I’d suggest to rename it to setTilesetImageURL and keep setTilesetImageFilename taking a String for compatibility.

Topic		Replies	Views
Java libtiled : Can't read input file Questions	2	1074	March 28, 2018
Libtiled java v1.2.3: NullPointer on accessing tiles Questions	2	1000	March 17, 2020
TiledMapReader error in Java Questions	3	1124	November 29, 2018
Tile animation with standard java MapReader Questions	2	1103	November 10, 2017
The file name is missing or inacessible; processing! Questions	0	594	April 10, 2018

Tilebmpfile is coming as null

Related topics